collections prep - use FQRN

linux-system-roles / tuned

An ansible role which configures tuned performance and power profiles

https://linux-system-roles.github.io/

MIT License

8 stars 11 forks source link

collections prep - use FQRN #3

Closed richm closed 4 years ago

richm commented 4 years ago

Prepare for collections - use fully qualified role name

nhosoi commented 4 years ago

BTW, may I ask why tuned does not run travis-ci/pr test? When I run tox -e molecule in the collection converted dir, this indentation error is reported.

--> Action: 'lint'
--> Executing Yamllint on files found in /path/to/collections/ansible_collections/fedora/system_roles/...
    /path/to/collections/ansible_collections/fedora/system_roles/roles/tuned/meta/main.yml
      9:3       error    wrong indentation: expected 4 but found 2  (indentation)

richm commented 4 years ago

BTW, may I ask why tuned does not run travis-ci/pr test? When I run tox -e molecule in the collection converted dir, this indentation error is reported.
--> Action: 'lint'
--> Executing Yamllint on files found in /path/to/collections/ansible_collections/fedora/system_roles/...
    /path/to/collections/ansible_collections/fedora/system_roles/roles/tuned/meta/main.yml
      9:3       error    wrong indentation: expected 4 but found 2  (indentation)

tuned isn't really supported by molecule. I never could get it to work. tuned doesn't want to run in a container, at least on some platforms

nhosoi commented 4 years ago

BTW, may I ask why tuned does not run travis-ci/pr test? When I run tox -e molecule in the collection converted dir, this indentation error is reported.
--> Action: 'lint'
--> Executing Yamllint on files found in /path/to/collections/ansible_collections/fedora/system_roles/...
    /path/to/collections/ansible_collections/fedora/system_roles/roles/tuned/meta/main.yml
      9:3       error    wrong indentation: expected 4 but found 2  (indentation)
tuned isn't really supported by molecule. I never could get it to work. tuned doesn't want to run in a container, at least on some platforms

I see... (;_;) Then, is it ok to fix (== open a pr) the indentation?

richm commented 4 years ago

I see... (;_;) Then, is it ok to fix (== open a pr) the indentation?

yes