search

linux-system-roles / vpn

Role for managing VPN/IPSec
https://linux-system-roles.github.io/vpn/
MIT License
8 stars 14 forks source link

use custom vpn_ipaddr filter #42

Closed richm closed 2 years ago

richm commented 2 years ago

Use a custom vpn_ipaddr filter which uses the ipaddress module. This is built-in to python3. Users will need to install ipaddress on python 2 controllers. All versions of EL7 include the python-ipaddress package. This is based on the ansible.netcommon.ipaddr filter, but with most of the functionality removed except that which is necessary for the VPN role.

richm commented 2 years ago

[citest]

richm commented 2 years ago

TODO:

richm commented 2 years ago

This means we can get rid of the dependency on ansible.netcommon, and we do not have to vendor it in.

nhosoi commented 2 years ago

@richm, I'm testing this pr with my baseos ci merge request.

This is a failed example from tests_host_to_unmanaged_host.yml. It complains openssl command not found. Is it possible to add it to the packages list?

TASK [linux-system-roles.vpn : generate psks] **********************************
/bin/sh: openssl: command not found
fatal: [sut -> localhost]: FAILED! => {"censored": "the output has been hidden due to the fact that 'no_log: true' was specified for this result"}
richm commented 2 years ago

Also means we can get rid of the dependency on netaddr - we will only require an extra dependency on python-ipaddress on EL7

richm commented 2 years ago

[citest]

richm commented 2 years ago

[citest]

richm commented 2 years ago

@nhosoi ok to merge?

nhosoi commented 2 years ago

@nhosoi ok to merge?

Give me one sec. I'm running the test one more time...