search

linux-test-project / ltp

Linux Test Project (mailing list: https://lists.linux.it/listinfo/ltp)
https://linux-test-project.readthedocs.io/
GNU General Public License v2.0
2.31k stars 1.01k forks source link

fix linking rt for glibc versions before 2.17 #1003

Closed guzhou2022 closed 1 year ago

guzhou2022 commented 1 year ago

https://github.com/linux-test-project/ltp/issues/997

metan-ucw commented 1 year ago

The changes looks good, however the commits are missing Signed-off-by line see: https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

metan-ucw commented 1 year ago

Can you please update the commit descriptions and add the missing Signed-off-by lines so that we can merge these patches?

guzhou2022 commented 1 year ago

Sorry, I will resubmit as soon as possible

From: "Cyril @.> Date:  Mon, Jul 3, 2023, 22:58 Subject:  Re: [linux-test-project/ltp] fix linking rt for glibc versions before 2.17 (PR #1003) To: @.> Cc: @.>, @.> Can you please update the commit descriptions and add the missing Signed-off-by lines so that we can merge these patches? — Reply to this email directly, view it on GitHubhttps://github.com/linux-test-project/ltp/pull/1003#issuecomment-1618548002, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A4PSEELP6JRYATVL67DU53DXOLMZ5ANCNFSM6AAAAAASXAYGYE. You are receiving this because you authored the thread.[image: https://github.com/notifications/beacon/A4PSEEPRWCAD3O74ZZPEGD3XOLMZ5A5CNFSM6AAAAAASXAYGYGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTAPEKSE.gif]Message ID: @.***>

pevik commented 1 year ago

Or just post here your real name and email and we will add it and merge.

guzhou2022 commented 1 year ago

My company's network prohibits connecting to external networks in the linux work environment and busy workdays, please help me merge this patch. Thanks very much！ My real name is zhou ci, and my email is @.***

From: "Petr @.> Date: Tue, Jul 4, 2023, 20:00 Subject: Re: [linux-test-project/ltp] fix linking rt for glibc versions before 2.17 (PR #1003) To: @.> Cc: @.>, @.> Or just post here your real name and email and we will add it and merge. — Reply to this email directly, view it on GitHubhttps://github.com/linux-test-project/ltp/pull/1003#issuecomment-1620115867, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A4PSEEMBW5QFW64L2ZLCGR3XOQAUPANCNFSM6AAAAAASXAYGYE. You are receiving this because you authored the thread.[image: https://github.com/notifications/beacon/A4PSEEPOVETY5XTH7REB6ETXOQAUPA5CNFSM6AAAAAASXAYGYGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTASEAZW.gif]Message ID: @.***>

pevik commented 1 year ago

It looks like you replied to email. Could you please add a comment, because in email github actually hides your email address. We also expect full name. See my Signed-off-by tag in https://github.com/linux-test-project/ltp/commit/353f0e4203139f3fc02fa2beb67cdcc7a05298d0 (basically any git commit has tag in form: Signed-off-by: sigYour Name <your@email>).

guzhou2022 commented 1 year ago

fix linking rt for glibc versions before 2.17

According to the manual page of clock_gettime(3), we should link with -lrt (only for glibc versions before 2.17). For glibc after 2.17, explicit linking with -lrt has no effect.

Signed-off-by: Ci Zhou zhouci@ruijie.com.cn

pevik commented 1 year ago

Merged, thank you!