search

linux-test-project / ltp

Linux Test Project (mailing list: https://lists.linux.it/listinfo/ltp)
https://linux-test-project.readthedocs.io/
GNU General Public License v2.0
2.28k stars 999 forks source link

ima_kexec.sh: Remove check_policy_readable #1021

Closed yup-21 closed 1 year ago

yup-21 commented 1 year ago

In ima_kexec.sh, check_policy_readable has been executed in require_ima_policy_content. Remove check_policy_readable; otherwise, it will miss ‘tst_brk TCONF’.

Signed-off-by: pengyu pengyu@kylinos.cn

pevik commented 1 year ago

I suppose you don't like tst_res TWARN "policy not readable, it might not contain required policy..." and tst_brk TBROK "unable to find a correct measurement", right? The problem why I have chosen this is because I didn't want to limit this testing just for kernels with CONFIG_IMA_READ_POLICY=y.

Also, it looks like you're quite active in LTP. Could you please start using our mailing list instead of opening github pull requests? Reason? More people can follow this. Particularly here, I could have Cc Mimi Zohar and linux-ingegrity kernel mailing list (I'd like to know at least Mimi's opinion about it).

yup-21 commented 1 year ago

After carefully reviewing the testcase, I agree that they should not be skipped simply, because there are scenarios where the policy is supported but kernels with CONFIG_IMA_READ_POLICY=n. To ensure proper testing in these scenarios, we should keep them as they are and close this pr.

I would love to use the mailing list, but I am not sure how to do it. Could you please show me how?

pevik commented 1 year ago

OK, closing.

ML: https://github.com/linux-test-project/ltp#developers-corner Just to subscribe to https://lists.linux.it/listinfo/ltp Instruction, how to send patches please search git format-patch and git send-email (some info is in our tutorial, but not enough: https://github.com/linux-test-project/ltp/wiki/C-Test-Case-Tutorial).