search

linux-test-project / ltp

Linux Test Project (mailing list: https://lists.linux.it/listinfo/ltp)
https://linux-test-project.readthedocs.io/
GNU General Public License v2.0
2.31k stars 1.01k forks source link

Drop fcntl08 since same checks are already performed by fcntl01 #1130

Closed ilmanzo closed 7 months ago

pevik commented 7 months ago

@ilmanzo Yes, @Avinesh is correct. Closing for now. Feel free first to implement fcntl01.c test to new API and then add all similar test variants there.

ilmanzo commented 7 months ago

@ilmanzo , just adding same comment here also. we are not testing the O_NONBLOCK flag in fcntl01.c test so fcntl08.c is not duplicate. And fcntl01.c is still based on old LTP API, so in my opinion we should first convert fcntl01.c test to new API and add all similar test variants there, then we can remove the duplicated test if there are any.

yeah you are right :) Thanks for the review. Reading open(2) man pages I (wrongly) assumed that O_NDELAY and O_NONBLOCK are the same thing ... Maybe could help to open an issue in order to explicit the need of fcntl01.c refactoring and have a clear "to-do-list" ? I think having explicit tasks would help to have more contributors on the project.

pevik commented 7 months ago

We usually don't open tickets for tests which needs rewrite into new API (it's quite obvious that any test which don't contain tst_test.h or tst_test.sh neither load them via other file needs rewriting into new API. But if it helps you, sure it's not a problem to open a ticket.

FYI we track in issues mainly missing test coverage (that takes long, thus it would be lost) and sometimes real bugs / regressions (unless they are reasonably quickly solved, they are then just discussed over mailing list).