search

linux-test-project / ltp

Linux Test Project (mailing list: https://lists.linux.it/listinfo/ltp)
https://linux-test-project.readthedocs.io/
GNU General Public License v2.0
2.29k stars 1.01k forks source link

NFSv4 ACL tests: cleanup, update, better integration, rewrite from python #548

Open pevik opened 5 years ago

pevik commented 5 years ago

There are some NFSv4 ACL tests in testcases/network/nfsv4/acl/ directory. They have been brought from some other test framework. They don't have it's framework, aren't installed. We should investigate whether they're useful and if yes, install them, create runtest file.

Also these tests use python, which is not optimal (#547).

pevik commented 4 years ago

Note, first we should investigate if these tests are having any value nowadays. NFS kernel developers are testing with pynfs, we should probably delete these tests.

pevik commented 4 years ago

https://patchwork.ozlabs.org/project/ltp/patch/20200720091449.19813-1-pvorel@suse.cz/#2487456 NFS kernel developer:

Looks like they may test some things (ACL enforcement, multi-client locking), that our other test suites don't. On the other hand, if nobody's actually running them then maybe it's on us to adopt them if we want them. (Not volunteering for now.)

pevik commented 4 years ago

As J. Bruce Fields (NFS and file locking kernel maintainer) consider them somehow useful, we should rewrite them to be useful. That involves understand NFS locking. Tests also needs to be better integrated into LTP, and preferably rewritten from python to shell or C.