search

linux-test-project / ltp

Linux Test Project (mailing list: https://lists.linux.it/listinfo/ltp)
https://linux-test-project.readthedocs.io/
GNU General Public License v2.0
2.33k stars 1.02k forks source link

test_controllers.sh is trying to call deprecated run_cpuacct_test.sh #800

Open Cypresslin opened 3 years ago

Cypresslin commented 3 years ago

While running the controllers test in the controllers subset, we found that the test_controllers.sh will complain about:

/opt/ltp/testcases/bin/test_controllers.sh: line 105: /opt/ltp/testcases/bin/run_cpuacct_test.sh: No such file or directory
/opt/ltp/testcases/bin/test_controllers.sh: line 106: /opt/ltp/testcases/bin/run_cpuacct_test.sh: No such file or directory

Source code in the test_controllers.sh:

if [ "$CPUACCOUNT_CONTROLLER" = "cpuacct" ] && [ "$CPUACCOUNT_CONTROLLER_VALUE" = "1" ]
then
    $LTPROOT/testcases/bin/run_cpuacct_test.sh 1;
    $LTPROOT/testcases/bin/run_cpuacct_test.sh 2;

A quick dig shows the run_cpuacct_test.sh has been deprecated with cpuacct test case rewrite in commit 1bdfee68c9cb04.

metan-ucw commented 3 years ago

@richiejp Can you please have a look at this as well?