search

linux-test-project / ltp

Linux Test Project (mailing list: https://lists.linux.it/listinfo/ltp)
https://linux-test-project.readthedocs.io/
GNU General Public License v2.0
2.3k stars 1.01k forks source link

Review and cleanup pipeio test #877

Open metan-ucw opened 2 years ago

metan-ucw commented 2 years ago

The test uses an old library tlibio.c that is stuck in the top level lib/ directory. If nothing else the tlibio.c should be moved into a separate library, e.g. libs/tlibio/ and cleaned up from the historical cruft.

Also the pipeio test is put into kernel/ipc/ directory and UNIX pipes are not exactly IPC, maybe kernel/io/ would be better home for the test.

Also the test is referenced from the ipc runtest file, that does not seem right either, ideally the ipc runtest file should disappear after this and issue #876 is solved.

Martchus commented 12 months ago

Looks like tlibio.h is also included by growfiles.c. I guess it could nevertheless be moved to libs/tlibio. I'm wondering what the benefit would be, though. I'm also not sure what "cleaned up from the historical cruft" means concretely.