search

linux-test-project / ltp

Linux Test Project (mailing list: https://lists.linux.it/listinfo/ltp)
https://linux-test-project.readthedocs.io/
GNU General Public License v2.0
2.3k stars 1.01k forks source link

Write test for futex_waitv() #880

Closed metan-ucw closed 11 months ago

metan-ucw commented 2 years ago

https://lwn.net/Articles/866112/ https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=595b28fb0c8949463d8ec1e485f36d17c870ddb2

There are some selftests but I haven't checked if the coverage is sufficient.

acerv commented 2 years ago

Maybe it's a bit straight forward as a suggestion, but why not bringing Linux kernel selftests inside LTP? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/futex

kamiccolo commented 2 years ago

Maybe it's a bit straight forward as a suggestion, but why not bringing Linux kernel selftests inside LTP? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/futex

I'm not so sure, how well could we manage different kernel versions with "integrated kselftests"? From the looks, it seems that we would need to rewrite those anyways adding "tst_kvercmp()" there and there. Please correct me if I'm wrong.

metan-ucw commented 2 years ago

There are many other problems in there, apart from the missing check for the syscall existence. These tests are written so that they are all executed by a single script, there is no proper result reporting etc. Also most of these tests should be already present in LTP, since the original futex tests the selftest are based on have been part of the LTP for years. And as these tests were rewritten and cleaned up there is no reason to do verbatim copy to LTP at all. We only need to implement LTP test for the recent additions that are not covered by LTP yet.

acerv commented 1 year ago

futex_waitv tests have been added inside LTP, so the ticket can be cosed