search

linux-test-project / ltp

Linux Test Project (mailing list: https://lists.linux.it/listinfo/ltp)
https://linux-test-project.readthedocs.io/
GNU General Public License v2.0
2.3k stars 1.01k forks source link

modify run_option_group_tests #881

Closed cheng191 closed 2 years ago

cheng191 commented 2 years ago

Signed-off-by: chengweibin chengweibin@uniontech.com

pevik commented 2 years ago

Thanks for your fix!

Your commit message is "modify run_option_group_tests", which describes what you did and not why you did. https://chris.beams.io/posts/git-commit/

You created new commit (and also add merge commit) which creates mess in git history. You were supposed to do: git pull -r, then modify file and do git commit --amend . to have just one single commit.

I fixed it and commit your change. https://github.com/linux-test-project/ltp/wiki#developers-corner