search

linux-test-project / ltp

Linux Test Project (mailing list: https://lists.linux.it/listinfo/ltp)
https://linux-test-project.readthedocs.io/
GNU General Public License v2.0
2.28k stars 999 forks source link

readahead02.c fixes #972

Open metan-ucw opened 1 year ago

metan-ucw commented 1 year ago

There are a couple things that should be fixed in the test:

We run the test with a loop device it will fail with ENOSPC if we pass -s bigger than the loop device, we should at least check if the device is large enough in the test setup.

The test should make use of use tst_parse_filesize() so that we can pass sizes with units e.g. -s 128M.

As we run the test inside a loop device I guess that we can also sync and drop caches just for the device, which should be faster than syncing and dropping the whole system. Possibly we just need to umount it and mount it again.

indumathiraju commented 1 year ago

Hi, Could you please tell what are the required configurations and packages for LTP to make all tests get Pass ?

Thank you

metan-ucw commented 1 year ago

@indumathiraju this is not really the right place to ask this question, this issue is about bugs in readahead02 test. Question like this are best to be raised on the project mailing list.

Avinesh commented 1 year ago

@indumathiraju , Please check - https://github.com/linux-test-project/ltp#readme LTP mailing list: http://lists.linux.it/listinfo/ltp

coolgw commented 1 year ago

https://patchwork.ozlabs.org/project/ltp/patch/20230118034409.23599-1-wegao@suse.com/

Martchus commented 9 months ago

Looks like the patch linked by @coolgw hasn't been merged yet. I'm wondering what was missing. Is there a way to display reviews in patchwork?

coolgw commented 9 months ago

@Martchus you can check v4, v3 etc in patchwork. There has some review comments. such as https://patchwork.ozlabs.org/project/ltp/patch/20230116111749.18865-1-wegao@suse.com/

Martchus commented 9 months ago

you can check v4, v3 etc in patchwork

I've been following your link. However, I'm wondering how one can navigate from one version to another in patchwork? (Or how can one search for patches? I haven't found a search form anywhere.)

There has some review comments.

Ah, so I understand that you're waiting for further feedback here.

pevik commented 9 months ago

you can check v4, v3 etc in patchwork

I've been following your link. However, I'm wondering how one can navigate from one version to another in patchwork? (Or how can one search for patches? I haven't found a search form anywhere.)

@Martchus Unfortunately patchwork does not connect series together, this functionality would have to be added. There is already ticket for it: https://github.com/getpatchwork/patchwork/issues/506

coolgw commented 1 month ago

https://patchwork.ozlabs.org/project/ltp/patch/20230118034409.23599-1-wegao@suse.com/ v5 version rejected.