search

linux-usb-gadgets / libusbgx

C library encapsulating the Linux kernel USB gadget configfs userspace API functionality
GNU General Public License v2.0
216 stars 72 forks source link

Fix assumption that sys/sysmacros.h is included. #28

Closed ghost closed 6 years ago

ghost commented 6 years ago

See https://sourceware.org/ml/libc-alpha/2015-11/msg00253.html.

pszewczyk commented 6 years ago

I think it could be done in single commit and also include description of the problem in commit message, not only in this pull request.

ghost commented 6 years ago

What do you want in the description? If you'd like it can be added when you merge. If you really won't merge the changes unless I redo the branch I made I suppose I will redo it, but I don't see the point in curating git commits. If the commits don't reflect the actual development process then what is the point?

I made so many commits to make sure I didn't add the directive in places it wasn't needed.

kopasiak commented 6 years ago

Commit should reflect the actual development but the should be meaningful not just a single line of code. Please squash them all together and write a good commit message that clarifies why you are doing it (please remember to provide the link from pull request message as it's great source)

kopasiak commented 6 years ago

Merged in #29