search

linux-usb-gadgets / libusbgx

C library encapsulating the Linux kernel USB gadget configfs userspace API functionality
GNU General Public License v2.0
216 stars 72 forks source link

libusbgx: fix --without-libconfig build against glibc-2.28 #37

Closed a3f closed 5 years ago

a3f commented 5 years ago

Commit 45c14ef4d5 ("libusbgx: fix build with glibc-2.28 since <sys/sysmacros.h> is no more included by <sys/types.h>") fixed this issue for the (default) --with-libconfig configuration, but building --without-libconfig still throws a linker error because makedev was assumed to be an external symbol in usbg_common.c.

Include <sys/sysmacros.h> there to address this.

Signed-off-by: Ahmad Fatoum \a.fatoum@pengutronix.de\

I've reviewed instances of /\b(minor|major|makedev)\b/ and it looks like the instance in usbg_common.c is the last remaining that doesn't have the sysmacros in scope.

kopasiak commented 5 years ago

Initially looks good to me. I'll try to merge it during weekend as I'm currently on a BT.

a3f commented 5 years ago

Hello @kopasiak, any news on this?

kopasiak commented 5 years ago

merged. Thank you for the fix and sorry for delay.