search

linux-usb-gadgets / libusbgx

C library encapsulating the Linux kernel USB gadget configfs userspace API functionality
GNU General Public License v2.0
216 stars 72 forks source link

Compilation fixes. #4

Closed aasimon closed 7 years ago

aasimon commented 7 years ago

Trivial fix for out-out-tree linking the examples. Fix to make --without-libconfig or --disable-gadget-schemes actually work.

(Sorry about the name confusion: xbbn is also me)

aasimon commented 7 years ago

Note that disabling gadget-schemes makes linking of (at least some of) the examples fail. So a bit more work is needed in order to make that work.

aasimon commented 7 years ago

That seem to do the trick.

aasimon commented 7 years ago

It appears that commit a3bcd69 (Link examples to out-of-tree usbgx library) is actually breaking things and the out-of-tree linking already worked with the existing code. So please ignore that commit.

kopasiak commented 7 years ago

Hi,

Sorry for not responding but I was on a sickness leave for over a week:(

I see that you reopened this so what's the current status?

aasimon commented 7 years ago

I closed it be accident... I'm kind-of new to github :-) The patches 07aa5c0 and 2e403c4 should still be applied.

kopasiak commented 7 years ago

Hi,

sorry for my late response but I was quite busy during last month. I checked your patches and I see that there is a problem which has to be fixed so thank you very much for pointing my attention to this.

I check your code but I think we should fix this in a little bit different way. As codding is sometimes much faster that describing what you think in a natural language I just wrote the code and created a pull request #6 . I would be glad if you could share your opinion about it and check if this fixes your issues.

Cheers, Krzysztof

kopasiak commented 7 years ago

Fixed in #6.