linux4sam / at91bootstrap

Second level bootloader for Microchip SoC (aka AT91)
https://www.linux4sam.org/linux4sam/bin/view/Linux4SAM/AT91Bootstrap4
114 stars 232 forks source link

lib/fdt: Constify input-only char* arguments #111

Closed lnksz closed 4 years ago

lnksz commented 4 years ago

The functions are called with constant character literals aka const char *

ret = of_get_node_offset(blob, "chosen", &nodeoffset);
ret = of_get_node_offset(blob, "memory", &nodeoffset);
ret = of_set_property(blob, nodeoffset, "bootargs", value, valuelen);
ret = of_set_property(blob, nodeoffset, "device_type", "memory", sizeof("memory"));
ret = of_set_property(blob, nodeoffset, "reg", data, valuelen);
ehristev commented 4 years ago

Hi, Could you please edit your commit message and add your Signed-off-by tag ? Thanks

lnksz commented 4 years ago

Sorry, I tried out the online edit-commit function of github. I re-created this in #112 from the command line...