linux4sam / at91bootstrap

Second level bootloader for Microchip SoC (aka AT91)
https://www.linux4sam.org/linux4sam/bin/view/Linux4SAM/AT91Bootstrap4
112 stars 232 forks source link

device: remove board_override_cmd_line() from sama5d3 #135

Closed edgar-bonet closed 3 years ago

edgar-bonet commented 3 years ago

This pull request addresses issue #126.

According to Nicolas Ferre, the Android-specific code in this function is not needed anymore. Then, this version of the function can be removed, and we can instead rely on the default, weak implementation defined in driver/load_kernel.c.

Incidentally, this fixes a bug, as this board_override_cmd_line() would return NULL unless CONFIG_LOAD_ANDROID was set.

Combined with Tony Han's patch to Config.in.kernel, this makes the Acqua board bootable by AT91Boostrap 4.

ehristev commented 3 years ago

@noglitch do you wish to add any tag to this patch ?

noglitch commented 3 years ago

@ehristev : Acked-by: Nicolas Ferre nicolas.ferre@microchip.com

ehristev commented 3 years ago

Applied, thanks !