search

linux4sam / at91bootstrap

Second level bootloader for Microchip SoC (aka AT91)
https://www.linux4sam.org/linux4sam/bin/view/Linux4SAM/AT91Bootstrap4
112 stars 232 forks source link

Output in .config for DDR is confusing #151

Closed 234d closed 2 years ago

234d commented 2 years ago

In driver/Config.in.dram the config options have a comment that looks like it belongs to corresponding config. But that's not how they're supposed to be used so in the final .config file the comment looks like it belongs to the config option below. Either remove the comment or change it to a help attribute. Or move the comment above each option but the choice menu gets cluttered with the comments, though that's kind of how it looks today but the comment would of course be above rather than below.

Example:

#
# DDR2 W9751G6KB 512 Mbit
#
CONFIG_DDR_W971GG6SB=y

#
# DDR2 W971GG6SB 1 Gbit
#
# CONFIG_DDR_AD220032D is not set

#
# LPDDR2 AD220032D 2 Gbit
#
# CONFIG_DDR_MT47H128M16 is not set
ehristev commented 2 years ago

Fixed by patch. Thanks for reporting !