search

linux4sam / at91bootstrap

Second level bootloader for Microchip SoC (aka AT91)
https://www.linux4sam.org/linux4sam/bin/view/Linux4SAM/AT91Bootstrap4
112 stars 232 forks source link

Makefile: restore target name when CONFIG_FATFS is not set #97

Closed jrbyrne closed 5 years ago

jrbyrne commented 5 years ago

Commit e60cccc4637d ("Config.in: add the dependency of CONFIG_IMAGE_NAME") made CONFIG_IMAGE_NAME a dependency of CONFIG_FATFS. This has the unwanted side effect of losing the target image component of the built binary filenames when CONFIG_FATFS is not defined. For example, what would previously have been built as "sama5d3xek-nandflashboot-uboot-3.8.12.bin" becomes "sama5d3xek-nandflashboot--3.8.12.bin" (note the two hyphens).

This commit fixes the problem by substituting default image names when CONFIG_IMAGE_NAME is undefined.

ehristev commented 5 years ago

Hi,

Thank you for the patch, could you add your Signed-off-by at the end of your commit message please?

Eugen

jrbyrne commented 5 years ago

Hi,

Sure, I've just re-pushed with an amended commit message.

James