cybdarren
commented
4 years ago Requested changes made…
Cheers, Darren
From: Cristian Birsan notifications@github.com Sent: 06 May 2020 16:18 To: linux4sam/dt-overlay-at91 dt-overlay-at91@noreply.github.com Cc: Darren Wenn - M91145 Darren.Wenn@microchip.com; Author author@noreply.github.com Subject: Re: [linux4sam/dt-overlay-at91] [dt-overlay-at91][PATCH] (#3)
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
@cristibirsan requested changes on this pull request.
Thank you for sending this and congratulations for your first patches !
There are some minor fixes needed before merging. I added them in the review.
Regards, Cristian
In sama5d27_som1_ek.itshttps://github.com/linux4sam/dt-overlay-at91/pull/3#discussion_r420807349:
@@ -178,5 +194,11 @@
description = "FDT overlay blob for ov5640 sensor";
fdt = "fdt_ov5640";
};+
-
thermo5 {
-
description = "FDY overlay for Thermo5 click";
You have a typo here FDY -> FDT
In sama5d27_som1_ek.itshttps://github.com/linux4sam/dt-overlay-at91/pull/3#discussion_r420809738:
+
-
fdt_thermo5 {
-
description = "Device Tree blob Thermo5 Click overlay";
-
data = /incbin/("./sama5d27_som1_ek/sama5d27_som1_ek_thermo5.dtbo");
-
type = "flat_dt";
-
arch = "arm";
-
compression = "none";
-
load = <0x23190000>;
-
hash@1 {
-
algo = "crc32";
-
};
-
hash@2 {
-
algo = "sha1";
-
};
-
};
No need for space here
In sama5d27_som1_ek/sama5d27_som1_ek_thermo5.dtsohttps://github.com/linux4sam/dt-overlay-at91/pull/3#discussion_r420873006:
@@ -0,0 +1,18 @@
+/dts-v1/;
Add license information here. We use SPDX-License-Identifier: (GPL-2.0+ OR MIT)
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/linux4sam/dt-overlay-at91/pull/3#pullrequestreview-406633497, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADU6NMXKH6ANWHVHLT7Q4ETRQF5SXANCNFSM4MZV4KEQ.
cristibirsan
Added Thermo5 click board support for sama5d27_som1_ek and sam9x60ek