egt-benchmark: git submodules are not initialized

linux4sam / meta-atmel

OpenEmbedded/Yocto Project layer for for Microchip SoC (aka AT91)

https://www.linux4sam.org/bin/view/Linux4SAM/YoctoProject

MIT License

90 stars 118 forks source link

egt-benchmark: git submodules are not initialized #212

Closed priv-kweihmann closed 1 year ago

priv-kweihmann commented 2 years ago

tool is using an external dependency https://github.com/linux4sam/egt-benchmark/tree/master/external, which doesn't seem to be fully initialized when using the git-fetcher compilation fails with src/main.cpp:7:10: fatal error: 'hayai.hpp' file not found

ldesroches commented 2 years ago

Hello,

How can I reproduce your issue, I have run a build and I have no issue to build this package.

Regards,

priv-kweihmann commented 2 years ago

Requires a not yet merged patch in bitbake (see https://lists.openembedded.org/g/openembedded-core/message/159995, resp. https://errors.yoctoproject.org/Errors/Build/137579/) - it isn't a problem as of now, but likely will break once upstream merges that feature. IMO that should happen very soon.

In my opinion the recipe should use the gitsm fetcher instead of plain git

Dharma-B commented 1 year ago

Fixes: https://github.com/linux4sam/meta-atmel/commit/492c4937c72fe53971f409746b6cdcb3f3dd754c