search

linux4sam / meta-atmel

OpenEmbedded/Yocto Project layer for for Microchip SoC (aka AT91)
https://www.linux4sam.org/bin/view/Linux4SAM/YoctoProject
MIT License
91 stars 120 forks source link

Kirkstone pixman error in .bbappend #237

Closed grahas closed 1 year ago

grahas commented 1 year ago

In meta-atmel/recipes-graphics/pixman/pixman_%.bbappend since it is appending it should have a space in the beginning or it will cause issues with that variable. ie SRC_URI:append = "file://0001-Revert-Initialize-temporary-buffers-in-general_compo.patch" -> SRC_URI:append = " file://0001-Revert-Initialize-temporary-buffers-in-general_compo.patch"

https://docs.yoctoproject.org/bitbake/dev/bitbake-user-manual/bitbake-user-manual-metadata.html#appending-and-prepending-override-style-syntax

gehariprasath commented 1 year ago

@grahas While it didn't throw any error/warnings when I tried to build pixman, I agree with you that this syntax not correct and a space needs to precede the file name. You can send me a PR if you would like to or I can fix this myself with your name in the Reported-by tag. Let me know how you would want to proceed. Thanks for noticing this.

grahas commented 1 year ago

Hi @gehariprasath, I made PR Update Append Syntax #238 . Thanks for helping take care of this :+1:

gehariprasath commented 1 year ago

The patch is now applied to kirkstone. Closing this issue.