linux4sam / meta-atmel

OpenEmbedded/Yocto Project layer for for Microchip SoC (aka AT91)
https://www.linux4sam.org/bin/view/Linux4SAM/YoctoProject
MIT License
91 stars 120 forks source link

Fix linuxptp and egt-media builds with latest yocto master #240

Open kraj opened 1 year ago

kraj commented 1 year ago

@kraj Is it 'videoconvertscale' or 'videocolorscale' ? Release note says it's videocolorscale. https://gstreamer.freedesktop.org/releases/1.22/

the name is what is used in oe-core for this plugin.

@ldesroches can you review this pls ?

kraj commented 1 year ago

@kraj We already have 'COMPATIBLE_MACHINE' to restrict only to specific machine type's. So this patch essentially does the same thing, isn't it ?

which patch are you referring to ? there are 4 in this PR. Regardless, if you are making recipes to trigger on COMPATIBLE_MACHINE thats fine as long as your intention is not to do so for generic recipes which has no particular reason other than you dont want to fix them for other SOCs. IOW forks of common packages and tools etc.

gehariprasath commented 1 year ago

@kraj We already have 'COMPATIBLE_MACHINE' to restrict only to specific machine type's. So this patch essentially does the same thing, isn't it ?

which patch are you referring to ? there are 4 in this PR. Regardless, if you are making recipes to trigger on COMPATIBLE_MACHINE thats fine as long as your intention is not to do so for generic recipes which has no particular reason other than you dont want to fix them for other SOCs. IOW forks of common packages and tools etc.

It's for the patch titled "optee: Limit sam specific changes to sam alone". This is specific to meta-atmel and our machines. So I guess it won't be a problem for generic recipes.