search

linuxboot / contest

Run continuous and on-demand system testing for real and virtual hardware
MIT License
17 stars 17 forks source link

TestRunner: Remove step stopping loop in RunMonitor #126

Closed rihter007 closed 2 years ago

rihter007 commented 2 years ago

Fixes https://github.com/linuxboot/contest/issues/62

codecov-commenter commented 2 years ago

Codecov Report

Merging #126 (c5974e6) into main (29d7b6d) will decrease coverage by 0.10%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   63.92%   63.81%   -0.11%     
==========================================
  Files         164      164              
  Lines       10321    10304      -17     
==========================================
- Hits         6598     6576      -22     
- Misses       3007     3013       +6     
+ Partials      716      715       -1
Flag Coverage Δ
e2e 49.75% <100.00%> (-0.01%) :arrow_down:
integration 55.14% <100.00%> (-0.16%) :arrow_down:
unittests 49.37% <100.00%> (-0.35%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/runner/test_runner.go 91.75% <100.00%> (+0.84%) :arrow_up:
pkg/runner/step_state.go 89.79% <0.00%> (-4.09%) :arrow_down:
pkg/runner/step_runner.go 89.23% <0.00%> (-1.16%) :arrow_down:
pkg/jobmanager/jobmanager.go 76.92% <0.00%> (-1.10%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rihter007 commented 2 years ago

Only one place where conditional variable is used is left will remove it next