codecov-commenter
commented
1 year ago Codecov Report
Patch coverage: 66.07% and project coverage change: -1.58 :warning:
Comparison is base (
57569d4) 63.37% compared to head (ab3087b) 61.79%.:exclamation: Current head ab3087b differs from pull request most recent head c13b022. Consider uploading reports for the commit c13b022 to get more accurate results
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #164 +/- ## =========================================== - Coverage 63.37% 61.79% -1.58% =========================================== Files 165 130 -35 Lines 10587 9196 -1391 =========================================== - Hits 6709 5683 -1026 + Misses 3134 2842 -292 + Partials 744 671 -73 ``` | Flag | Coverage Δ | | |---|---|---| | e2e | `49.52% <54.57%> (+1.00%)` | :arrow_up: | | integration | `56.85% <63.51%> (+2.30%)` | :arrow_up: | | unittests | `45.65% <46.68%> (-3.93%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/linuxboot/contest/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [cmds/admin\_server/server/server.go](https://app.codecov.io/gh/linuxboot/contest/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y21kcy9hZG1pbl9zZXJ2ZXIvc2VydmVyL3NlcnZlci5nbw==) | `0.00% <0.00%> (ø)` | | | [cmds/admin\_server/storage/mongo/mongo.go](https://app.codecov.io/gh/linuxboot/contest/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y21kcy9hZG1pbl9zZXJ2ZXIvc3RvcmFnZS9tb25nby9tb25nby5nbw==) | `8.56% <0.00%> (+0.37%)` | :arrow_up: | | [pkg/api/event.go](https://app.codecov.io/gh/linuxboot/contest/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cGtnL2FwaS9ldmVudC5nbw==) | `77.77% <ø> (ø)` | | | [pkg/cerrors/cerrors.go](https://app.codecov.io/gh/linuxboot/contest/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cGtnL2NlcnJvcnMvY2Vycm9ycy5nbw==) | `12.50% <ø> (ø)` | | | [pkg/event/frameworkevent/framework.go](https://app.codecov.io/gh/linuxboot/contest/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cGtnL2V2ZW50L2ZyYW1ld29ya2V2ZW50L2ZyYW1ld29yay5nbw==) | `75.00% <ø> (ø)` | | | [pkg/event/testevent/test.go](https://app.codecov.io/gh/linuxboot/contest/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cGtnL2V2ZW50L3Rlc3RldmVudC90ZXN0Lmdv) | `100.00% <ø> (ø)` | | | [pkg/job/reporting.go](https://app.codecov.io/gh/linuxboot/contest/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cGtnL2pvYi9yZXBvcnRpbmcuZ28=) | `100.00% <ø> (ø)` | | | [pkg/jobmanager/stop.go](https://app.codecov.io/gh/linuxboot/contest/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cGtnL2pvYm1hbmFnZXIvc3RvcC5nbw==) | `83.33% <0.00%> (ø)` | | | [pkg/loggerhook/httphook.go](https://app.codecov.io/gh/linuxboot/contest/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cGtnL2xvZ2dlcmhvb2svaHR0cGhvb2suZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/target/locker.go](https://app.codecov.io/gh/linuxboot/contest/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cGtnL3RhcmdldC9sb2NrZXIuZ28=) | `100.00% <ø> (ø)` | | | ... and [78 more](https://app.codecov.io/gh/linuxboot/contest/pull/164?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
mimir-d
xaionaro
What
Here I do substitution of
xcontexttogo-beltandsignallers. The APIs are mostly compatible, so this was a pretty mechanistic stupid job (could mostly be done withsed).Caveats:
xcontextbinds together three different things: observability API, context and signals (currently used to propagatePausesignal across the application). And it is problematic to make the migration of observability API and signals separately, because if I migrate one thing, it breaks another thing. So I migrate them together in one commit.xcontextbothCancelandPauseas processed by the same handler. But after migrationCancelis processed by standardcontextAPI, whilePauseis processed by additional signal-handler. Because of that it is now no unified API between these two.Why
TLDR:
xcontextis succeeded bygo-belt.xcontextexisted for some time, there was gathered the feedback and in resultgo-beltis a better version of similar ideas.More details
The previous design had few very serious problems:
Caveatsabove) and is not scalable horizontally (the amount of observability tools are limited).context.Context, which causes different inconveniences with necessity to type-cast and do other similar stuff. Also the custom context type started to propagate to public APIs which never was the intention (public APIs should always use only the standard context).xcontextis on life-support, whilego-beltis actually supported.There were also other known (less serious) problems, and in
go-beltall that is solved.How
The PR consists of 4 commits:
Pause(though it can propagate other signals as well). This package mostly just replicates the related code ofxcontext.xcontexttogo-beltandsignalleraccordingly. This is mostly mechanistic change, which stupidly changes the code to an equivalent. Sorry for a huge commit, but it is difficult to split without breaking functionality :(xcontextis deleted (packageperfis kept and moved out ofxcontext).