tlaurion
commented
4 months ago @UndeadDevel im confused.
If I understand this correctly, the feature is not implemented by coreboot, nor ed2k, but the EC firmware. Coreboot is responsible to expose acpi tables of EC, and then the system76_acpi kernel module is injected by OS if ids match, system76_acpi kernel module exposes the additional thresholds files under BAT0, which tlp can interact with at runtime?
So my understanding is that EC firmware doesn't have those thresholds fixated, and something went south to match what system76_acpi kernel module is looking for to expose those for user customization only from ed2k, hence the regression.
This is a simple hypothesis, but if low level stuff was there in EC, and compatible with system76_acpi kernel module (not causing regression), THEN it would mean that Heads could pack this additional required kernel module as well, and have a nice configuration menu added to change those values from Heads which would change EC values. Same for fan speeds.
Why system76_acpi kernel module (most probably is not loaded anymore because I'd mismatch) does not expose the configurable thresholds anymore?
Probably related https://github.com/linuxboot/heads/issues/1639#issuecomment-2059884079 @pietrushnic? Cc @macpijan @macpijan
Is your feature request related to a problem? Please describe. See https://github.com/Dasharo/dasharo-issues/issues/285 (coreboot allows configuring battery charging limits both from the BIOS as well as the OS); this used to work in Heads 2.1 for me as well on my NV41.
See https://github.com/Nitrokey/heads/issues/35 (Setting battery charging limits worked in NK Heads 2.1, but not anymore in NK Heads 2.4 and 2.4.1). In that issue @daringer says that it's an upstream issue with Heads.
Describe the solution you'd like Allow configuring battery charging limits (and possibly other coreboot configurable settings) from within Heads or the OS.
Describe alternatives you've considered Unfortunately right now there doesn't seem to be an alternative other than removing Heads and using Coreboot (or going back to Heads 2.1). The usually suggested solutions online, e.g.
tlporsmbios-utilsall require that the firmware make the relevant system files, usually/sys/class/power_supply/BAT0/charge_control_start_thresholdand/sys/class/power_supply/BAT0/charge_control_end_threshold, available to the OS, as that is how those utilities set the new limits.Additional context The focus is on the battery charging limits, as that's not just a convenience feature, but also important to help preserve battery life for laptop users.