fix: dcc-dock-plugin icon tweak

linuxdeepin / dde-dock

Dock application of DDE

GNU Lesser General Public License v3.0

207 stars 124 forks source link

fix: dcc-dock-plugin icon tweak #988

Closed kegechen closed 6 months ago

kegechen commented 6 months ago

控制中心中dock的插件统一混合颜色暗色主题时填充白色，浅色主题填充黑色

Issue: https://github.com/linuxdeepin/developer-center/issues/6454

kegechen commented 6 months ago

提供给控制中心的图标不能由设计直接提供对应的dci资源吗，我们只需要返回QIcon不就行了吗？

确实可以用 qicon 的read/write方法，这样以来iconengine的read/write的实现

遗憾的是 DBuiltinIconEngine/XdgIconLoaderEngine write 只是记录的iconname，并没有把图标数据写到QDataStream中 dci 图标会写数据，所以dci图标确实可以，不过dock的其他插件没法要求必须要dci图标

deepin-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kegechen, tsic404

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/dde-dock/blob/master/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment