search

linuxdeepin / deepin-editor

Text editor for DDE
GNU General Public License v3.0
104 stars 64 forks source link

feat:Add status label on findbar and replacebar #277

Closed Fozei closed 6 months ago

Fozei commented 6 months ago

It is convinent to know how many results we have and which result is focused when we perform searching and replacing operations.

Like VS Code or other text editor do.

And more ,I want to known which IDE are you using for develop deepin-apps, it is very hard for me to code this project by vscode and the Qt Creator seems have different UI when I build from it.

deepin-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Fozei

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/deepin-editor/blob/master/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
deepin-ci-robot commented 6 months ago

Hi @Fozei. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Fozei commented 6 months ago

Do not review it, I find some mistake in my code, keep it pending.