linuxdeepin / deepin-editor

Text editor for DDE
GNU General Public License v3.0
104 stars 64 forks source link

feat: add search status label on findbar and replacebar #278

Open Fozei opened 5 months ago

Fozei commented 5 months ago

desc: 在查找和替换组件上,增加指示当前选中是第几个和总共有多少个查找结果的标签

deepin-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Fozei

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/deepin-editor/blob/master/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
deepin-ci-robot commented 5 months ago

Hi @Fozei. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rb-union commented 4 months ago

很好的提交!不过对于大文本下使用遍历的方式有待商榷,有较明显的性能问题。

deepin-bot[bot] commented 4 months ago

TAG Bot

New tag: 6.0.18 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #282

Fozei commented 3 months ago

@rb-union Thank you for your reply!确实是这样,我在编码时也考虑到了这一层,但是受制于QT组件本身的限制和个人水平,暂时没有想到更好的办法。在编码时,我甚至参考了VS Code的源码,发现它在至多寻找到19999个出现次数时,就停止再往下查找了。我个人认为,目前我们的编辑器,在加载大文本时,也是有比较明显的性能问题的,所以还是硬着头皮提了这个PR ^_^。希望深度有机会的话,可以把我们的编辑器重构一把哈哈,做成编辑器届的瑞士军刀,小巧而好用,加油!Thanks again !

deepin-bot[bot] commented 2 months ago

TAG Bot

New tag: 6.5.0 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #286

deepin-bot[bot] commented 1 month ago

TAG Bot

New tag: 6.5.1 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #289

deepin-bot[bot] commented 1 month ago

TAG Bot

New tag: 6.5.2 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #291

deepin-bot[bot] commented 1 month ago

TAG Bot

New tag: 6.5.3 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #294