feat: adapt treeland - Githubissues

linuxdeepin / deepin-editor

Text editor for DDE

GNU General Public License v3.0

104 stars 64 forks source link

feat: adapt treeland #285

Closed rb-union closed 2 months ago

rb-union commented 2 months ago

Adapt Treeland, disable wayland settings in Treeland enviroment. Update system version check, return V23 if greater than "23".

Log: Adapt Treeland. Influence: Wayland

deepin-ci-robot commented 2 months ago

deepin pr auto review

关键摘要:

在Utils::getSystemLan()函数中，版本比较的逻辑从字符串比较更改为整数比较，可能会影响版本23的判断。
Utils::isTreeland()函数中使用了qEnvironmentVariable来判断桌面环境，这可能会导致跨平台兼容性问题。
在main.cpp文件中，添加了对wayland环境的检查，但没有处理非wayland环境的情况。

是否建议立即修改:

pengfeixx commented 2 months ago

[是否满足兼容性要求] Y [是否满足commit提交规范] Y [是否满足编码规范] Y [Review结论] Pass [Fail原因] N/A

deepin-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rb-union, starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/deepin-editor/blob/master/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment