search

linuxdeepin / deepin-movie-reborn

Video player for DDE
GNU General Public License v3.0
78 stars 66 forks source link

Subtitle Online Search ... #9

Closed aiamuzz closed 3 years ago

aiamuzz commented 6 years ago

Hi,

I have never come across any other video player that does an online search for subtitles ... its unbelievably fantastic !!!

But the online search is a 'blind search' ... the reason i call it so, is because it searches for languages that i do not need ... usually the online search returns 3 subtitle files ... i am interested in an English subtitle and the search returns subtitles for 3 languages that are not English ... and moreover the search returns the file name of the subtitle file rather than the language ... one has to choose the 3 results one by one to know which language is loaded.

I believe this feature may be in its nascent(early) stage in Deepin Movie ... I hope to see this blind search be a more targeted search based on the language of choice ... of the user.

PS : reference to an existing implementation - Popcorn TIme software shows up subtitles for all languages ... If Deepin Movie could do the same show up all possible languages similar to 'popcorn time' ... would be fantastic.

aiamuzz commented 6 years ago

The above issue has been 'elegantly' addressed and implemented across another open source project 'Popcorn Time' ...

deepinscreenshot_20180114145808

hope to see an as elegant an implementation of the "subtitle language" feature on Deepin-Movie as well ...

sonald commented 6 years ago

online sub search depends on the provider (there are very few options we can choose), which may contains no such meta thing as language. so it's not accurate. but I think it can be improved later.

we did plan a feature like switch language, but turns out we can not find enough legal video sources that contains language info. never know 'popcorn time', I'll check it out later :)

aiamuzz commented 6 years ago

thanks for looking into it ... you MUST try IT out ... it it is a nifty piece of software ... 'popcorn time' ... it might just become your go to software for watching movies ... it marries the world of movie torrents and the feel of an online movie in way it seems ... soooo unreal !!! :)

sonald commented 6 years ago

I'im in China, so it's actually unreal :)

aiamuzz commented 6 years ago

hahahahaha ... i know ... its addictive ... popcorn-time !!! :) besides watching the movie directly ... you also have the option of adding the movies to your torrent downloader with its magnet link ... the torrents are very healthy for download.

so its subtitle option is impressive isn't it ? would love to see a similar implementation on deepin-movie ... :)

dkameneck commented 6 years ago

Hey all!

I found out today that opensubtitles.org has API that everyone can use.

Did you tought of implementing more api's for online search? This will also lead to more subtitles found

I will start adding opensubtitles API when I get enough time, just checking if you already have some plans regarding this?

sonald commented 6 years ago

I'm pretty busy these days. any patches are welcome.

sonald commented 6 years ago

FYI, IINA does both use shooter and opensubtitles. the problem is that opensubtitles api needs authentication and that brings some complexity.

justforlxz commented 3 years ago

Sorry, this issue will be closed soon. If it is necessary to discuss it again, please create a new issue.