search

linuxdeepin / deepin-terminal

deepin-terminal-reborn
GNU General Public License v3.0
146 stars 69 forks source link

fix: Crash when show/close setting dialog. #325

Closed rb-union closed 10 months ago

rb-union commented 10 months ago

设置弹窗在构建时设置了父控件,而父控件(终端窗口)销毁 时同时销毁设置弹窗.导致关闭后在其它终端窗口打开设置 弹窗时,访问已销毁的弹窗对象,程序崩溃. 调整设置弹窗生命周期由 Service 维护,不过仍需要设置 父窗口以实现正常的显示坐标计算.

Log: 修复在多个窗口上切换显示设置弹窗崩溃的问题. Bug: https://pms.uniontech.com/bug-view-28636.html Influence: SettingDialog

pengfeixx commented 10 months ago

[是否满足兼容性要求] Y [是否满足commit提交规范] Y [是否满足编码规范] Y [Review结论] Pass [Fail原因] N/A

deepin-ci-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, rb-union

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/deepin-terminal/blob/release/eagle/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rb-union commented 10 months ago

/merge

lzwind commented 10 months ago

/merge

deepin-bot[bot] commented 10 months ago

This pr cannot be merged! (status: unknown)