search

linuxdeepin / deepin-terminal

deepin-terminal-reborn
GNU General Public License v3.0
146 stars 69 forks source link

fix: cursor position error when display completion #337

Closed asterwyx closed 8 months ago

asterwyx commented 8 months ago

Triggering completion when cursor is in command might lead to cursor position error cause patch of bug 67102 trims trailing '\b' which is not suitable for this case. As 67102 is not totally resolved(I can still reproduce this), we just simply revert the modification.

Log: fix cursor position error when display completion Issue: https://github.com/linuxdeepin/developer-center/issues/5208 Related-To: https://pms.uniontech.com/bug-view-67102.html Partially-Revert: https://github.com/linuxdeepin/deepin-terminal/commit/24ec7f9ae5395985e120e5225cd2fc37968a41b6

deepin-ci-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArchieMeng, asterwyx, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/deepin-terminal/blob/master/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment