fix: compile error - Githubissues

linuxdeepin / deepin-terminal

deepin-terminal-reborn

GNU General Public License v3.0

146 stars 69 forks source link

fix: compile error #347

Closed rb-union closed 4 months ago

rb-union commented 4 months ago

Fix cimpile error: header file not included.

Log: fix compile error

deepin-ci-robot commented 4 months ago

deepin pr auto review

关键摘要:

在tabbar.cpp文件中新增的#include <QMimeData>是否确实需要，如果没有在其他文件中使用，应该移除以避免不必要的依赖。
在termbasedialog.cpp文件中新增的DWIDGET_USE_NAMESPACE宏定义是否有必要，如果项目已经遵循了命名空间的使用，则可以移除。
检查新增的#include <DGuiApplicationHelper>是否与项目中的其他部分存在冲突，如果有冲突，需要进行调整。

是否建议立即修改:

是，应该立即检查并处理上述问题，以保持代码的整洁性和可维护性。

myk1343 commented 4 months ago

[是否满足兼容性要求] Y [是否满足commit提交规范] Y [是否满足编码规范] Y [Review结论] Pass [Fail原因] N/A

jeffshuai commented 4 months ago

[是否满足兼容性要求] Y [是否满足commit提交规范] Y [是否满足编码规范] Y [Review结论] Pass [Fail原因] N/A

deepin-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rb-union, starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/deepin-terminal/blob/release/eagle/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

rb-union commented 4 months ago

/merge