fix: crashed when access DSGApplication::id early

linuxdeepin / dtkcore

Deepin Toolkit, core module

Other

73 stars 85 forks source link

fix: crashed when access DSGApplication::id early #418

Closed 18202781743 closed 3 months ago

18202781743 commented 3 months ago

Add fallback, using fileName of /proc/self/exe as AppId. Remove assert for empty appId.

18202781743 commented 3 months ago

https://github.com/linuxdeepin/dde-application-manager/pull/211

deepin-bot[bot] commented 3 months ago

Doc Check bot :green_circle: Document Coverage Check Passed!

deepin-ci-robot commented 3 months ago

deepin pr auto review

关键摘要:

在formatAppId函数中，使用了正则表达式来替换非法字符，但没有考虑到中文和特殊字符的情况。
QFile和QIODevice的使用没有显式地关闭文件，可能会导致资源泄露。
qCDebug和qCWarning的使用在生产环境中可能不合适，应该使用qDebug和qWarning来区分调试和错误信息。
代码中的qt_assert已被Q_ASSERT替代，建议统一代码风格。

是否建议立即修改: 是

deepin-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, zccrs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/dtkcore/blob/master/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment