linuxdeepin / dtkcore

Deepin Toolkit, core module
Other
73 stars 85 forks source link

refactor: remove LoggingRules interface #421

Closed Whale107 closed 3 months ago

Whale107 commented 3 months ago
deepin-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Whale107

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/dtkcore/blob/develop/eagle/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
deepin-ci-robot commented 3 months ago

deepin pr auto review

关键摘要:

是否建议立即修改: 是

kegechen commented 3 months ago

@18202781743 砍下dconfig 有没有遗漏的

18202781743 commented 3 months ago

@18202781743 砍下dconfig 有没有遗漏的

dde-app-services项目跟这个isDefaultValue 有关联, 是一起升么, DConfigFile里添加了对appid,subpath,filename的检查,