chore: add nullptr check

linuxdeepin / dtkcore

Deepin Toolkit, core module

Other

73 stars 85 forks source link

chore: add nullptr check #423

Closed kegechen closed 3 months ago

kegechen commented 3 months ago

nullptr check

deepin-ci-robot commented 3 months ago

deepin pr auto review

关键摘要:

在else if语句中，条件判断逻辑可能存在问题。原代码中是检查m_fallbackConfig是否存在，而修改后的代码是检查m_dsgConfig是否存在，这可能会导致不同的行为。
代码修改后，如果m_dsgConfig存在但未设置RULES_KEY的值，var可能会是nullptr，这可能不是预期的行为。

是否建议立即修改:

deepin-bot[bot] commented 3 months ago

Doc Check bot :green_circle: Document Coverage Check Passed!

deepin-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/dtkcore/blob/master/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment