chore: use '&&' and '||' instead of 'and' and 'or'

linuxdeepin / dtkcore

Deepin Toolkit, core module

Other

73 stars 85 forks source link

chore: use '&&' and '||' instead of 'and' and 'or' #426

Closed zsien closed 3 months ago

zsien commented 3 months ago

一些项目使用了 -fno-operator-names，会导致编译失败

deepin-ci-robot commented 3 months ago

deepin pr auto review

关键摘要:

在unescapeFromObjectPath函数中，修改了条件判断语句，增加了括号以避免歧义。
在getAppIdFromAbsolutePath函数中，移除了不必要的空格，使代码更紧凑。

是否建议立即修改:

否，这次提交的修改主要是风格和格式上的，没有改变代码的逻辑。因此，如果没有其他的代码质量或功能性问题，这些修改可以不用立即进行。不过，保持代码风格的一致性是一个好习惯，可以在下一次代码提交时包含这些风格上的改动。

deepin-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ComixHe, kegechen, zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/dtkcore/blob/master/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

deepin-bot[bot] commented 3 months ago

Doc Check bot :green_circle: Document Coverage Check Passed!

zsien commented 3 months ago

/merge

deepin-bot[bot] commented 3 months ago

This pr cannot be merged! (status: unstable)