fix: remove unnecessary link libraries

linuxdeepin / dtkcore

Deepin Toolkit, core module

Other

73 stars 85 forks source link

fix: remove unnecessary link libraries #432

Closed rb-union closed 3 days ago

rb-union commented 1 month ago

These two libraries are used to detect text encoding, but they are actually loaded dynamiclly. Not need to link libraries.

deepin-bot[bot] commented 3 weeks ago

TAG Bot

New tag: 5.6.34 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #433

deepin-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kegechen, rb-union

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/dtkcore/blob/master/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

deepin-ci-robot commented 2 weeks ago

deepin pr auto review

关键摘要:

移除了对ICU::uc和uchardet库的链接，需要确认这些库是否不再被项目使用。
检查Qt${QT_VERSION_MAJOR}::CorePrivate的替代实现，因为移除了uchardet可能会影响字符识别功能。

是否建议立即修改:

是，需要确保移除的库不会影响项目功能，并且检查替代实现是否正确。