fix: incomplete display for menu

18202781743 commented 5 months ago

Adding bounding check when show menu.

Issue: https://github.com/linuxdeepin/developer-center/issues/8472

deepin-ci-robot commented 5 months ago

deepin pr auto review

关键摘要:

代码中直接使用了Screen.desktopAvailableWidth和Screen.desktopAvailableHeight，但这些属性在Qt6中已经被移除。建议使用QApplication.instance().primaryScreen().availableSize()来替代。
函数onClicked现在接受一个mouse参数，但在函数体中并没有使用该参数。如果不需要，应该移除。
在if条件判断中，使用了control.mapFromGlobal(0, Screen.desktopAvailableHeight - contextMenu.height).y来获取坐标，但这种用法在Qt6中已经废弃，建议使用control.mapFromGlobal(QPoint(0, Screen.desktopAvailableHeight - contextMenu.height))来替代。

是否建议立即修改: 是

deepin-bot[bot] commented 5 months ago

Doc Check bot :green_circle: Document Coverage Check Passed!

deepin-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/dtkdeclarative/blob/master/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

linuxdeepin / dtkdeclarative

fix: incomplete display for menu #345

deepin pr auto review