fix: column layout fills the space available

linuxdeepin / dtkdeclarative

Other

19 stars 38 forks source link

fix: column layout fills the space available #371

Closed FeiWang1119 closed 1 month ago

FeiWang1119 commented 1 month ago

it's senseless that column layout fills the space available in ControlGroup, so set Layout.fillHeight to false

Log:

deepin-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/dtkdeclarative/blob/dev/animation/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

deepin-ci-robot commented 1 month ago

deepin pr auto review

关键摘要:

在ColumnLayout的itemLayout中添加了Layout.fillHeight: false属性，这可能会影响布局的预期行为。需要确认这是否是预期的更改。
移除了clip属性，这可能会影响子控件的显示范围，需要确保这是否是预期的更改。

是否建议立即修改:

是，需要确认这些更改是否符合设计要求，并确保它们不会引入新的问题。如果这些更改是错误的，应该立即恢复或进行必要的修正。

deepin-bot[bot] commented 1 month ago

Doc Check bot :green_circle: Document Coverage Check Passed!