Closed xionglinlin closed 1 month ago
Doc Check bot :yellow_circle: some documents missing! File | Line | Symbol |
---|---|---|
src/dquickwindow.h | 82 | Dtk::Quick::DQuickWindowAttached::DQuickWindowAttached |
src/dquickwindow.h | 84 | QQuickWindow * Dtk::Quick::DQuickWindowAttached::window |
src/dquickwindow.h | 164 | void Dtk::Quick::DQuickWindowAttached::enabledChanged |
src/dquickwindow.h | 165 | void Dtk::Quick::DQuickWindowAttached::windowRadiusChanged |
src/dquickwindow.h | 166 | void Dtk::Quick::DQuickWindowAttached::borderWidthChanged |
src/dquickwindow.h | 167 | void Dtk::Quick::DQuickWindowAttached::borderColorChanged |
src/dquickwindow.h | 168 | void Dtk::Quick::DQuickWindowAttached::shadowRadiusChanged |
src/private/dquickwindow_p.h | 71 | DWindowManagerHelper::WmWindowTypes Dtk::Quick::DQuickWindowAttachedPrivate::wmWindowTypes |
src/private/dquickwindow_p.h | 72 | DWindowManagerHelper::MotifFunctions Dtk::Quick::DQuickWindowAttachedPrivate::motifFunctions |
src/private/dquickwindow_p.h | 73 | DWindowManagerHelper::MotifDecorations Dtk::Quick::DQuickWindowAttachedPrivate::motifDecorations |
src/private/dquickwindow_p.h | 75 | QList<DQuickBehindWindowBlur*> Dtk::Quick::DQuickWindowAttachedPrivate::blurList |
src/private/dquickwindow_p.h | 76 | QQuickPath* Dtk::Quick::DQuickWindowAttachedPrivate::clipPath |
src/private/dquickwindow_p.h | 77 | QQuickTransition* Dtk::Quick::DQuickWindowAttachedPrivate::overlayExitedTransition |
src/private/dquickwindow_p.h | 78 | QQmlComponent* Dtk::Quick::DQuickWindowAttachedPrivate::loadingOverlay |
/review @18202781743
关键摘要:
qmlplugin_plugin.cpp
文件中,新增的头文件<DPlatformHandle>
是否必要,如果DPlatformHandle
是必要的,建议检查是否有重复包含或依赖问题。DPlatformHandleForeign
结构体的命名应遵循项目的命名规范,确保一致性。updateValue
函数模板的实现可能存在逻辑错误,特别是在处理DTK_GUI_NAMESPACE::DPlatformHandle::EffectScenes
和DTK_GUI_NAMESPACE::DPlatformHandle::EffectTypes
时,应确保call
函数的参数与value
类型一致。setWindowEffect
和setWindowStartUpEffect
函数的实现中,对handle
的存在性检查是必要的,但可能需要更详细的错误处理或日志记录。windowEffect
和windowStartUpEffect
私有属性可能不需要公开,因为它们可以通过setWindowEffect
和setWindowStartUpEffect
函数访问和修改。windowEffect
和windowStartUpEffect
的Q_PROPERTY声明应确保与实际使用的类型一致。eventFilter
函数的重写可能需要更详细的错误处理和日志记录,以确保窗口事件处理逻辑的正确性。是否建议立即修改: 是
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: 18202781743, xionglinlin
The full list of commands accepted by this bot can be found here.
/forcemerge
This pr force merged! (status: unstable)
add two interface setWindowEffect and setWindowStartUpEffect
Issue: https://github.com/linuxdeepin/developer-center/issues/10322