linuxdeepin / dtkdeclarative

Other
20 stars 40 forks source link

fix: Adjust menu styles #411

Closed ArchieMeng closed 1 week ago

ArchieMeng commented 2 weeks ago

Bug: https://pms.uniontech.com/bug-view-276581.html https://pms.uniontech.com/bug-view-279723.html Log: Adjust menu styles

deepin-bot[bot] commented 2 weeks ago

TAG Bot

New tag: 5.7.1 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #401

deepin-ci-robot commented 1 week ago

deepin pr auto review

代码审查意见:

  1. FloatingPanel.qml:

    • 删除了Loader组件,如果这是有意为之,需要确认是否有替代方案来处理OutsideBoxBorder的逻辑。
    • 如果OutsideBoxBorder的逻辑被删除,需要确保相关的功能在其他地方得到了实现。
  2. FlowStyle.qml:

    • separator组件的lineTopPaddinglineBottomPadding属性被设置为0,这可能会影响分隔线的显示效果,需要确认这是否符合设计要求。
    • backgroundbackgroundNoBlur属性的normal颜色值被直接设置为RGBA值,建议使用颜色选择器来管理颜色值,以便于维护和一致性。
    • itemTextseparatorText属性的normalDark颜色值被修改,需要确认这些修改是否符合UI设计规范。
  3. Menu.qml:

    • implicitWidth属性被减去10,这可能会影响菜单的布局,需要确认这是否符合设计要求。
    • contentItem组件的topPaddingbottomPadding属性被修改,需要确认这些修改是否符合设计要求。
    • highlightRect组件的anchors.leftMarginanchors.rightMargin属性被设置为0,这可能会影响高亮区域的显示效果,需要确认这是否符合设计要求。
    • highlightRect组件的radius属性被修改为1,这可能会影响高亮区域的圆角效果,需要确认这是否符合设计要求。
  4. MenuItem.qml:

    • rightPadding属性被设置为0,这可能会影响菜单项的布局,需要确认这是否符合设计要求。
    • leftPaddingrightPadding属性的计算方式可能需要调整,以确保菜单项的布局正确。

总体来说,这些修改可能会影响UI的显示效果和布局,需要进一步确认这些修改是否符合设计要求和UI规范。同时,建议在代码中添加注释,说明这些修改的原因和影响。

deepin-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, ArchieMeng

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/dtkdeclarative/blob/master/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ArchieMeng commented 1 week ago

/merge

deepin-bot[bot] commented 1 week ago

This pr cannot be merged! (status: unstable)

ArchieMeng commented 1 week ago

/forcemerge

deepin-bot[bot] commented 1 week ago

This pr force merged! (status: unstable)