search

linuxdeepin / dtkwidget

Deepin Toolkit, widget module for DDE look and feel
Other
206 stars 144 forks source link

fix: redefinition of verticalTabs #532

Closed asterwyx closed 1 year ago

asterwyx commented 1 year ago

Function verticalTabs is exposed by qtabbar_p.h as constexpr static inline, original definition in dtabbar.cpp will lead to an redefinition error. Just rename dtk's implementation.

Note: Probably we should replace private implementaion with Qt's implementation after all versions of Qt expose this function. Log: fix redefinition of verticalTabs

deepin-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asterwyx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/dtkwidget/blob/master/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
deepin-bot[bot] commented 1 year ago

Doc Check bot :green_circle: Document Coverage Check Passed!