fix: 修复大多数按钮不响应enter事件

linuxdeepin / dtkwidget

Deepin Toolkit, widget module for DDE look and feel

Other

203 stars 144 forks source link

fix: 修复大多数按钮不响应enter事件 #569

Closed kegechen closed 4 months ago

kegechen commented 4 months ago

修复大多数按钮不响应enter事件,仅支持DApplication应用

Log: 修复大多数按钮不响应enter事件 Bug: https://pms.uniontech.com/bug-view-253935.html Influence: 按钮响应键盘回车事件

cherry-pick form: https://gerrit.uniontech.com/c/dtkwidget/+/239241

kegechen commented 4 months ago

@Whale107

deepin-bot[bot] commented 4 months ago

Doc Check bot :green_circle: Document Coverage Check Passed!

deepin-ci-robot commented 4 months ago

deepin pr auto review

关键摘要:

在新添加的代码中使用了 dynamic_cast，建议检查是否有必要进行类型转换，并确保转换的安全性。
使用 Q_EMIT 进行信号发射时，没有检查 btn 是否为 nullptr，可能会导致运行时错误。
对于 QEvent::KeyPress 的处理，应该确保 obj 是 focusWidget()，以避免不必要的重定向。

是否建议立即修改:

kegechen commented 4 months ago

use QPlatformTheme::ButtonPressKeys for pressing buttons

https://codereview.qt-project.org/c/qt/qtbase/+/394849

deepin-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kegechen, zccrs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/dtkwidget/blob/master/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kegechen commented 4 months ago

/retest

kegechen commented 4 months ago

/retest

kegechen commented 4 months ago

/forcemerge

deepin-bot[bot] commented 4 months ago

This pr force merged! (status: blocked)