fix: crash when follower was destroyed

linuxdeepin / dtkwidget

Deepin Toolkit, widget module for DDE look and feel

Other

206 stars 144 forks source link

fix: crash when follower was destroyed #572

Closed kegechen closed 6 months ago

kegechen commented 6 months ago

Bug: https://pms.uniontech.com/bug-view-254383.html Issue: https://github.com/linuxdeepin/developer-center/issues/8563

deepin-ci-robot commented 6 months ago

deepin pr auto review

关键摘要:

将QWidget *follower{nullptr};和QWidget *target{nullptr};从具体的QWidget指针更改为QPointer<QWidget>，这是一个好的实践，因为它提高了代码的可维护性和灵活性。

是否建议立即修改:

否，因为这个提交中的代码更改看起来是合理的，没有明显的错误或需要立即修复的问题。但是，如果有更多的上下文代码，可能需要进一步的审查来确认是否有其他潜在的问题。

deepin-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/dtkwidget/blob/master/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kegechen commented 6 months ago

/forcemerge

deepin-bot[bot] commented 6 months ago

This pr force merged! (status: blocked)

deepin-bot[bot] commented 6 months ago

Doc Check bot :green_circle: Document Coverage Check Passed!