Closed zty199 closed 4 months ago
Hi @zty199. Thanks for your PR. :smiley:
Hi @zty199. Thanks for your PR.
I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Doc Check bot :green_circle: Document Coverage Check Passed!
TAG Bot
New tag: 5.6.31 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #583
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: kegechen, zty199
The full list of commands accepted by this bot can be found here.
关键摘要:
baseSize()
更改为QSize(128, 128)
可能会导致图标显示不正确,因为原始大小可能与baseSize()
不同。需要确认图标是否确实需要调整为128x128像素。// TODO: wait for checking
表明可能存在未完成的工作,应该确认是否已经完成了所有必要的检查。windowHandle()
,但没有检查windowHandle()
是否返回了一个有效的窗口句柄。应该添加对windowHandle()
返回值的检查,以确保窗口存在且可以访问。是否建议立即修改:
windowHandle()
的返回值,以确保窗口可以被正确处理。/merge
This pr cannot be merged! (status: blocked)
/forcemerge
This pr force merged! (status: blocked)
when compiled with Qt6, product icon size is set to windowHandle().baseSize() which is not the same as compiled with Qt5 (fixed size 128x128)
Log: use 128x128 pixmap in DAboutDialog::setProductIcon