linuxdeepin / dtkwidget

Deepin Toolkit, widget module for DDE look and feel
Other
203 stars 144 forks source link

fix: wrong product icon size in DAboutDialog #580

Closed zty199 closed 2 months ago

zty199 commented 3 months ago

when compiled with Qt6, product icon size is set to windowHandle().baseSize() which is not the same as compiled with Qt5 (fixed size 128x128)

Log: use 128x128 pixmap in DAboutDialog::setProductIcon

deepin-ci-robot commented 3 months ago

Hi @zty199. Thanks for your PR. :smiley:

deepin-ci-robot commented 3 months ago

Hi @zty199. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
deepin-bot[bot] commented 3 months ago

Doc Check bot :green_circle: Document Coverage Check Passed!

deepin-bot[bot] commented 2 months ago

TAG Bot

New tag: 5.6.31 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #583

deepin-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kegechen, zty199

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/dtkwidget/blob/master/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
deepin-ci-robot commented 2 months ago

deepin pr auto review

关键摘要:

是否建议立即修改:

kegechen commented 2 months ago

/merge

deepin-bot[bot] commented 2 months ago

This pr cannot be merged! (status: blocked)

kegechen commented 2 months ago

/forcemerge

deepin-bot[bot] commented 2 months ago

This pr force merged! (status: blocked)