fix: DMessageManager::sendMessage cause crash

zty199 commented 4 months ago

when compiled with Qt6, in sendMessage_helper, seems that content could be nullptr when QWebEngineView is DMainWindow's centralWidget

Log: add judgment whether content is nullptr in sendMessage_helper

deepin-bot[bot] commented 4 months ago

TAG Bot

New tag: 5.6.31 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #583

deepin-ci-robot commented 4 months ago

deepin pr auto review

关键摘要:

代码中使用了findChildren<T>方法来查找子对象，但没有检查content是否为nullptr，可能会导致空指针解引用。
在循环中，text_message_count的初始化应该放在循环内部，以避免在每次迭代时都进行重复的计数。
循环中没有对message进行任何操作，如果只是为了计数，可以考虑直接使用findChildren而不需要创建临时对象。
新增的注释// TransientType 类型的通知消息，最多只允许同时显示三个应该放在循环外部，以便于理解代码的意图。

是否建议立即修改: 是

deepin-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kegechen, zty199

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/dtkwidget/blob/master/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

linuxdeepin / dtkwidget

fix: DMessageManager::sendMessage cause crash #584

deepin pr auto review