Closed Whale107 closed 2 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Whale107
The full list of commands accepted by this bot can be found here.
Doc Check bot :yellow_circle: some documents missing! File | Line | Symbol |
---|---|---|
include/widgets/dmessagemanager.h | 29 | DMessageManager * DMessageManager::instance |
include/widgets/dmessagemanager.h | 32 | void DMessageManager::sendMessage |
include/widgets/dmessagemanager.h | 33 | void Dtk::Widget::DMessageManager::sendMessage |
include/widgets/dmessagemanager.h | 34 | bool DMessageManager::setContentMargens |
src/widgets/private/dmessagemanager_p.h | 23 | QPropertyAnimation* Dtk::Widget::DMessageManagerPrivate::m_aniGeometry |
src/widgets/private/dmessagemanager_p.h | 24 | QPropertyAnimation* Dtk::Widget::DMessageManagerPrivate::m_aniOpacity |
src/widgets/private/dmessagemanager_p.h | 25 | QParallelAnimationGroup* Dtk::Widget::DMessageManagerPrivate::m_aniGroup |
src/widgets/private/dmessagemanager_p.h | 26 | QLabel* Dtk::Widget::DMessageManagerPrivate::m_label |
src/widgets/private/dmessagemanager_p.h | 21 | Dtk::Widget::DMessageManagerPrivate::DMessageManagerPrivate |
src/widgets/private/dmessagemanager_p.h | 28 | Dtk::Widget::DMessageManagerPrivate::D_DECLARE_PUBLIC |
src/widgets/private/dmessagemanager_p.h | 18 | Dtk::Widget::DMessageManagerPrivate |
关键摘要:
DFloatingMessage
类的init()
方法中,使用了connect
函数来连接动画组的finished
信号,但没有提供槽函数。这可能导致槽函数未连接,无法处理动画完成后的逻辑。DMessageManagerPrivate
类的构造函数中,m_aniGroup
的初始化应该包括QPropertyAnimation::DeleteWhenStopped
特性。DMessageManagerPrivate
类的setContentMargins
方法中,应该检查content
是否为nullptr
,以避免潜在的空指针解引用。DMessageManagerPrivate
类的eventFilter
方法中,对于event
类型为QEvent::ChildRemoved
的情况,应该添加对watched
是否为nullptr
的检查,以避免潜在的空指针解引用。DMessageManagerPrivate
类的drawPrimitive
方法中,使用Qt::NoPen
代替了QPen
,但没有提供QPen
的初始化参数,这可能会导致绘制的矩形没有边框。DMessageManagerPrivate
类的drawPrimitive
方法中,对于pe
为DStyle::PrimitiveRect
的情况,使用了frameRadius
变量,但没有提供该变量的初始化。DMessageManagerPrivate
类的drawPrimitive
方法中,对于pe
为DStyle::PrimitiveRoundedRect
的情况,使用了frameRadius
变量,但没有提供该变量的初始化。DMessageManagerPrivate
类的drawPrimitive
方法中,对于pe
为DStyle::PrimitivePath
的情况,使用了frameRadius
变量,但没有提供该变量的初始化。DMessageManagerPrivate
类的drawPrimitive
方法中,对于pe
为DStyle::PrimitiveImage
的情况,使用了frameRadius
变量,但没有提供该变量的初始化。DMessageManagerPrivate
类的drawPrimitive
方法中,对于pe
为DStyle::PrimitiveText
的情况,使用了frameRadius
变量,但没有提供该变量的初始化。DMessageManagerPrivate
类的drawPrimitive
方法中,对于pe
为DStyle::PrimitiveCustom
的情况,使用了frameRadius
变量,但没有提供该变量的初始化。是否建议立即修改: 是
增加应用内通知动画
Log: