fix: xwayland item can't get input

wineee commented 6 months ago

log: missing focus setting

deepin-ci-robot commented 6 months ago

deepin pr auto review

关键摘要:

在StackWorkspace.qml中，forcePositionToSurface属性的添加可能会影响其他依赖这个属性的代码部分。需要确认这一改动是否与整体代码库的逻辑一致。
QmlHelper.workspaceManager.layoutOrder.get(stackLayout.item.currentWorkspaceId).wsid的引入替代了原有的stackLayout.item.currentWorkspaceId，这可能意味着StackWorkspace现在依赖于一个特定的layoutOrder结构来获取wsid，需要确保这种结构的变化不会导致其他部分出现问题。
在onSurfaceAdded和onSurfaceRemoved函数中，直接操作QmlHelper.xwaylandSurfaceManager和treelandForeignToplevelManager可能会导致这些管理器的状态不一致，建议使用更封装的方法来处理这些操作。
FocusScope中forcePositionToSurface的逻辑判断较为复杂，建议重构以提高可读性。

是否建议立即修改: 是

deepin-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justforlxz, wineee

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[debian/deepin/OWNERS](https://github.com/linuxdeepin/treeland/blob/master/debian/deepin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

wineee commented 6 months ago

/merge

linuxdeepin / treeland

fix: xwayland item can't get input #254

deepin pr auto review