Please always use the latest appimagetool

linuxdeploy / linuxdeploy-plugin-appimage

Plugin for linuxdeploy. Creates AppImages from AppDirs.

https://github.com/linuxdeploy/linuxdeploy

34 stars 15 forks source link

Please always use the latest appimagetool #3

Closed probonopd closed 5 years ago

probonopd commented 5 years ago

Please always use the latest appimagetool.

linuxdeploy as of today uses a very outdated one, d18552 from October(!)

me@host:~$ Downloads/linuxdeploy-x86_64.AppImage --appimage-version
Version: d18552

Leading to errors we have long since fixed: https://github.com/AppImage/appimage.github.io/pull/1025#issuecomment-450584060

TheAssassin commented 5 years ago

Your check doesn't make much sense, it's the runtime version you're querying there, isn't it?

The issue belongs to https://github.com/linuxdeploy/linuxdeploy-plugin-appimage, and as said before, keeping this kind of stuff up to date with a "super basic" infrastructure such as Travis is very hard...

Will trigger a new build to update linuxdeploy-plugin-appimage, and then update linuxdeploy to include the latest appimage plugin build.

probonopd commented 5 years ago

I assume that --appimage-version gives the version of the runtime, which is identical to the version of appimagetool, since both come from the same build in the same repo.